Notice: Undefined offset: 1 in ...

[KarlBee]

Hi there,

Could someone tell me what this actually means?

I have my own local server running on my PC and on one include I get this error:

Notice: Undefined offset: 1 in c:\program files\www\inc\header_inc.php on line 21

Line 21 relates to this:

preg_match('/href="([^"]+)"/', $line, $url); 

And this is the complete code:

<?php
$menu = <<<MENU
    <ul>
      <li><a href="/" title="Homepage">Home</a></li>
      <li><a href="/colophon/" title="All about">Colophon</a></li>
      <li><a href="/webdesign/" title="service">Web Design</a></li>
      <li><a href="/hosting/" title="hosting packages">Hosting</a></li>
      <li><a href="/pcsupport/" title="PC Support">PC Support</a></li>
      <li><a href="/contact/" title="Contact information">Contact</a></li>
    </ul>
MENU;

$lines = split("\n", $menu);
foreach ($lines as $line) {
    $current = false;
    preg_match('/href="([^"]+)"/', $line, $url);
    if (substr($_SERVER["REQUEST_URI"], 0, 5) == substr($url[1], 0, 5)) {
        $line = str_replace('<a h', '<a id="active" h', $line);
        }
    echo $line."\n";
}
?>

I commented out the error handling in php.ini but the error still is there.

Any ideas?

Thanks
Karl

[Buddha]

Off the top of my head....

    if (substr($_SERVER["REQUEST_URI"], 0, 5) == substr($url['1'], 0, 5)) { 

Just add those quotes to $url.

[sdjl]

Also, you haven't assigned your preg_match code to a variable.
I'm assuming you want to use that otherwise it's kind of pointless having it

preg_match('/href="([^"]+)"/', $line, $url); 

Should be something like so:

$variable = preg_match('/href="([^"]+)"/', $line, $url); 

David

[keylope]

You also be getting that if $url didn't find a match. Then there would be no offset to find.

You might want to either first check if $url is empty and if not, then go ahead and do your comparison.

For debugging purposes, echo the array $url and maybe you'll be able to see what is going wrong.